Adds timeout to pipeline start #741
Conversation
tekton-robot
added
the
size/S
tekton-robot
added
the
approved
docs/cmd/tkn_pipeline_start.md
Outdated
| @@ -47,6 +47,7 @@ two parameters (foo and bar) | |||
| -s, --serviceaccount string pass the serviceaccount name | |||
| --showlog show logs right after starting the pipeline | |||
| --task-serviceaccount strings pass the service account corresponding to the task | |||
| -t, --timeout string timeout for pipelinerun (default "1h") | |||
There was a problem hiding this comment.
I don't think we should set a shorthand flag for this, let's keep the shorthand flag for things that are going to be used a lot in the future...
There was a problem hiding this comment.
It makes sense to remove this shorthand.
Should we also remove the same from task start to maintain consistency?
There was a problem hiding this comment.
if we have shipped in a release we can't remove it :( unless we go by a deprecation process (which we still need to be documented)
|
/hold |
tekton-robot
added
the
do-not-merge/hold
Close #706 This adds a timeout option to `tkn pipeline start` command timeout is string variable and value can be in format `1h10m2s` default timeout value is `1h` Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, danielhelfand, piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@piyush-garg Can we remove the hold? Any reason for it? |
|
yeah that was set by piyush for my previous request to remove the /hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Close #706
This adds a timeout option to
tkn pipeline startcommandtimeout is string variable and value can be in format
1h10m2sdefault timeout value is
1hSigned-off-by: Pradeep Kumar pradkuma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes